Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AWS SNS Sink #111

Merged
merged 9 commits into from
May 9, 2023
Merged

feat: AWS SNS Sink #111

merged 9 commits into from
May 9, 2023

Conversation

jshlbrd
Copy link
Contributor

@jshlbrd jshlbrd commented May 9, 2023

Description

  • Adds a sink for AWS SNS
    • Adds new internal package for SNS (internal/aws/sns)
    • Adds a new deployment example for publish/subscribe patterns (examples/aws/pubsub)
  • Refactors several sink methods (non-breaking change)
  • Fixes recursive returns in the Kinesis Firehose and SQS internal packages
  • Adds new TODOs for v1.0.0

Motivation and Context

Adding support for pub/sub messaging patterns via SNS seemed like a natural fit for the project, and I've already added documentation to the v0.9.1 beta that shows some example architectures.

While working on this I came across the other items described above -- not all directly related to SNS, but otherwise all are improvements in the sink package.

How Has This Been Tested?

The new pub/sub example was integration tested in a development AWS account.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshlbrd jshlbrd marked this pull request as ready for review May 9, 2023 02:36
@jshlbrd jshlbrd requested a review from a team as a code owner May 9, 2023 02:36
@jshlbrd jshlbrd merged commit 47e948f into main May 9, 2023
@jshlbrd jshlbrd deleted the jshlbrd/feat/sns-sink branch May 9, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants