Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoscale): Dynamic Kinesis Scaling with Thresholds #144

Merged
merged 5 commits into from
Mar 14, 2024

Conversation

jshlbrd
Copy link
Contributor

@jshlbrd jshlbrd commented Mar 11, 2024

Description

  • Adds a setting to cmd/autoscale that configures an upper and lower threshold for triggering Kinesis scaling events
  • Adds a tag to any scaled Kinesis streams that is used to disrupt runaway scaling events
  • Updates the Kinesis scaling strategy to be dynamic (more shards at the low end and less shards at the high end)
  • Updates Kinesis datapoints to support scaling up and down across any time range

Motivation and Context

These changes make the Kinesis autoscale app closer to the deprecated sample solution provided by AWS and adds some new features (like dynamic scaling). The threshold setting is partially based on DynamoDB's auto scaling solution, but operating around the limitations of the Kinesis UpdateShardCount API.

In the future we may adjust the dynamic scaling pattern, which would result in a patch version bump.

How Has This Been Tested?

This has been tested end-to-end on several production data pipelines.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshlbrd jshlbrd marked this pull request as ready for review March 12, 2024 23:13
@jshlbrd jshlbrd requested a review from a team as a code owner March 12, 2024 23:13
@jshlbrd jshlbrd merged commit 079fda9 into main Mar 14, 2024
6 checks passed
@jshlbrd jshlbrd deleted the jshlbrd/autoscale/dynamic-scaling branch March 14, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants