fix(kinesis): remove Kinesis aggregation size and count limits #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Substation uses the `internal/aggregate` package to buffer events with consideration to buffer, size, counts, and durations which shadow the checks here with adherence to Kinesis limits in a more user friendly way. Inclusion of the size checks here allowed events between 25KiB and 1MiB to be sent as empty events to destinations.
jshlbrd
approved these changes
May 3, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Substation uses the
internal/aggregatepackage to buffer events with consideration to buffer size, record counts, and durations which shadow the checks here with adherence to Kinesis limits in a more user friendly way.Motivation and Context
Inclusion of the size checks here allowed events between 25KiB and 1MiB to be sent as empty events to destinations.
How Has This Been Tested?
The fix has been tested on the internal pipeline containing events ranging from 10KiB to 1MiB with no issues.
Types of changes
Checklist: