Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transform): Empty Aggregated Kinesis Records #171

Merged
merged 1 commit into from
May 6, 2024

Conversation

jshlbrd
Copy link
Contributor

@jshlbrd jshlbrd commented May 4, 2024

Description

  • Fixes an edge case where the AWS Kinesis send transform can send an empty aggregated record

Motivation and Context

This is a fix that is in addition to #168.

There's an edge case where an empty aggregated Kinesis record can be sent if a single record is between ~0.9999 MB and 1 MB. Aggregated Kinesis records have a format and contain more data than a naked record, so there is a small chance that the naked record cannot actually fit inside an aggregated record and be successfully sent to the Kinesis service (due to the 1 MB record service limit).

This record is silently dropped, but since this causes an issue identical to this, it may be worth raising the same error for this edge case.

How Has This Been Tested?

This is running on some high-volume production data pipelines that are known to have this edge case.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshlbrd jshlbrd marked this pull request as ready for review May 6, 2024 15:17
@jshlbrd jshlbrd requested a review from a team as a code owner May 6, 2024 15:17
@jshlbrd jshlbrd merged commit 7c519fe into main May 6, 2024
4 checks passed
@jshlbrd jshlbrd deleted the jshlbrd/fix/transform-kinesis-record branch May 6, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants