feat(transform): Add Customizable Errors to MetaErr #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellcromancer
approved these changes
May 21, 2024
| Type: "utility_err", | ||
| }, | ||
| "error_messages": []string{ | ||
| "test error", |
There was a problem hiding this comment.
tests: we should consider adding an additional test with regular expressions in the error _messages.
There was a problem hiding this comment.
Do you mean a regular expression with special characters? These are all regular expressions.
There was a problem hiding this comment.
Yeah I meant with special characters such as wildcard globs. This way any future refactor or changes in this processor that attempt another approach like strings.Contains(err.Error(), error_message) to do the matching don't regress in functionality.
There was a problem hiding this comment.
Ah yep, that's a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This transform catches all errors, but there are some cases where only specific errors should be caught while others should crash the application. By default this option is the same as the existing solution, and it matches the behavior used by
ErrorMessageselsewhere in the app (https://github.com/brexhq/substation/blob/main/internal/aws/config.go#L96).How Has This Been Tested?
Added unit test that shows it catching errors when configured.
Types of changes
Checklist: