Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): AWS CloudWatch Embedded Metrics Dimensions #179

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

jshlbrd
Copy link
Contributor

@jshlbrd jshlbrd commented Jun 5, 2024

Description

  • Fixes dimensions in the AWS CloudWatch Embedded Metrics destination

Motivation and Context

This fixes a bug that causes multiple attributes to be incorrectly assigned to dimensions in the metric (discovered while testing #178 in a production pipeline). The fix has these dimensions:

"Dimensions":[["FunctionName","FreshnessType"]]

The incorrect dimensions are:

"Dimensions":[["FunctionName"],["FreshnessType"]]

This bug doesn't impact the metric value, but it does affect filters in CloudWatch (and may affect downstream systems).

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshlbrd jshlbrd marked this pull request as ready for review June 5, 2024 21:09
@jshlbrd jshlbrd requested a review from a team as a code owner June 5, 2024 21:09
@jshlbrd jshlbrd merged commit d6b6c42 into main Jun 6, 2024
4 checks passed
@jshlbrd jshlbrd deleted the jshlbrd/fix/metrics-cw-dimensions branch June 6, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants