Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transform): Add Storage Class Support to AWS S3 #189

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

jshlbrd
Copy link
Contributor

@jshlbrd jshlbrd commented Jun 25, 2024

Description

  • Adds support for configuring the storage class setting on the AWS S3 transform

Motivation and Context

This makes it possible to upload objects with unique storage class settings directly to an S3 bucket, which is useful if the transform is being used for the purpose of archiving data.

Another way to do this is with a lifecycle rule, but there are caveats to using that method, such as the object needing to stay in Standard storage for a minimum number of days and the additional cost of transitioning objects between storage classes.

The list of valid storage class strings is here.

How Has This Been Tested?

This has been E2E tested in a production environment for multiple days.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshlbrd jshlbrd marked this pull request as ready for review June 28, 2024 16:42
@jshlbrd jshlbrd requested a review from a team as a code owner June 28, 2024 16:42
@jshlbrd jshlbrd merged commit 63b96be into main Jul 1, 2024
4 checks passed
@jshlbrd jshlbrd deleted the jshlbrd/feat/tf-s3-storage branch July 1, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants