Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd): Pre-Compile Demo Config #247

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

jshlbrd
Copy link
Collaborator

@jshlbrd jshlbrd commented Oct 3, 2024

Description

  • Fixes an issue where the CLI tool substation demo cannot be run from any location

Motivation and Context

The existing substation demo command relies on the substation.libsonnet file in the project's root, and this causes an issue if the demo is not run from a path relative to that file. This pre-compiles the config so that the demo can be run from anywhere.

How Has This Been Tested?

Reinstall the CLI tool and run substation demo from any directory.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshlbrd jshlbrd marked this pull request as ready for review October 3, 2024 14:38
@jshlbrd jshlbrd requested a review from a team as a code owner October 3, 2024 14:38
@andrew-kline andrew-kline merged commit 81d50b8 into main Oct 3, 2024
8 checks passed
@andrew-kline andrew-kline deleted the jshlbrd/fix/cmd-demo branch October 3, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants