-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): Upgrade to Latest Minor Versions #266
Conversation
github.com/sirupsen/logrus v1.9.3 | ||
github.com/spf13/cobra v1.8.1 | ||
github.com/tidwall/gjson v1.17.1 | ||
github.com/tidwall/gjson v1.18.0 // Upgrades require SemVer bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the intent that a upgrade to new features in gjson
can give users new features and should be considered a features, but this specific upgrade to v1.18
seems to be a performance improvement. Since this isn't necessarily a Substation feature we might not need a version bump for this specific upgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tldr on this is that we shouldn't make assumptions about why a dependency bumped their version the way that they did -- they know their code better than we do. It's low effort (and not very impactful on users) for us to bump our own version whenever these packages do.
In this case, the changes look like it should have been a patch release, but for some reason it's not and I don't think we need to put much thought into why and how it affects our own versioning. (The caveat to this is if they break a unit test with a non-breaking update, then that's different and we should be more thoughtful about upgrading.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, regardless we have other content to bump our own patch release version. Semantically this specific upgrade is more of a chore than a feature 👍
github.com/sirupsen/logrus v1.9.3 | ||
github.com/spf13/cobra v1.8.1 | ||
github.com/tidwall/gjson v1.17.1 | ||
github.com/tidwall/gjson v1.18.0 // Upgrades require SemVer bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, regardless we have other content to bump our own patch release version. Semantically this specific upgrade is more of a chore than a feature 👍
Description
gjson
had a minor version update which requires a new release in SubstationMotivation and Context
If any exported packages directly expose the functionality of a dependency, then we need to version Substation similarly to that dependency.
gjson
went fromv1.17.1
tov1.18.0
, so this is PR is considered a feature to also bump Substation up to a new minor release.How Has This Been Tested?
Types of changes
Checklist: