fix(condition): handling of missing source and/or target keys #277
+149
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds additional handling of missing source and/or target keys in condition package number equal to and string equal to.
Motivation and Context
Fix for issue:Condition Package Zero Value Matches Can Be Inaccurate #263.
Current behaviour of condition package does not contain source key or target key's object path existence check. This caused unexpected behaviour:
When only src key is present but the path doesn't exist, condition package inaccurately matches on zero value and empty string.
When both source key and target key are present but both paths do not exist, the number equal to and string equal to return true.
This adds checks thus
How Has This Been Tested?
Types of changes
Checklist: