feat: DNS and IP Database Processing #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshlbrd
changed the title
shellcromancer
requested changes
Dec 8, 2022
process/ip_database.go
Outdated
| ipdb "github.com/brexhq/substation/internal/ip/database" | ||
| ) | ||
|
|
||
| var ipDatabasers = make(map[string]ipdb.OpenCloser) |
There was a problem hiding this comment.
style: rename to ipDatabases after the interface change?
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Currently the team at Brex runs DNS and IP address enrichment in a separate sub-system of our threat detection platform, but we identified an opportunity to migrate this into Substation. IP address enrichment is the most complex of these for two reasons:
The project's use of lazy loading, configuration through environment variables, and the ability to contextually retrieve files from local disk, HTTP(S), and AWS S3 solve many of these issues. As a starting point, I've added support for the free MaxMind and IP2Location databases.
The handling of open files in the IPDatabase processor required the addition of a Close method to each applicator interface; this allows each processor to define it's own teardown process (in the case of IPDatabase, it's closing the open database readers).
How Has This Been Tested?
The changes were integration tested using the two new examples files. I can provide a link to a privately hosted MaxMind database so that the reviewer(s) can check that the code is working as expected.
Types of changes
Checklist: