Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DNS errors #50

Merged
merged 1 commit into from
Dec 19, 2022
Merged

fix: DNS errors #50

merged 1 commit into from
Dec 19, 2022

Conversation

jshlbrd
Copy link
Contributor

@jshlbrd jshlbrd commented Dec 19, 2022

Description

  • Adds an ErrorOnFailure field to the DNS processor

Motivation and Context

Querying DNS with unknown data is likely to result in resolution failures, so this adds a field to explicitly enable errors for certain calls in the processor. This mimics functionality in the Lambda processor and will make its way into other processors through a refactor in 2023.

This also adds a new pattern for querying Team Cymru's Malware Hash Registry.

How Has This Been Tested?

Unit tested via process/example_test.go (change the IP address to something that doesn't exist, such as 127.0.0.2). Tests for the MHR pattern are available internally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshlbrd jshlbrd marked this pull request as ready for review December 19, 2022 17:52
@jshlbrd jshlbrd requested a review from a team as a code owner December 19, 2022 17:52
@jshlbrd jshlbrd merged commit 2c9e524 into main Dec 19, 2022
@jshlbrd jshlbrd deleted the jshlbrd/fix/dns-errors branch December 19, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants