Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground): trim quotes from environment variables #282

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

jtan-brex
Copy link
Contributor

Description

This trims the quotes from environment variables set via substation playground to mimic the behaviour of export in bash.

Motivation and Context

Often times environment variables are copied from cloud providers eg AWS identity center. Copied token would have "" wrapped and those will be trimmed by export locally.
The os.Setenv will treat the "" as literal, this difference handling cause authentication failure.

How Has This Been Tested?

Build and tested locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jtan-brex jtan-brex requested a review from a team as a code owner November 28, 2024 22:09
@jtan-brex jtan-brex changed the title fix(playground): trim quotes from environment variable variables fix(playground): trim quotes from environment variables Nov 28, 2024
@jtan-brex jtan-brex merged commit 83bd0e8 into main Nov 28, 2024
8 checks passed
@jtan-brex jtan-brex deleted the jtan-fix-playground-env-variables branch November 28, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants