Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies #395

Merged
merged 4 commits into from
Nov 11, 2020
Merged

Fix dependencies #395

merged 4 commits into from
Nov 11, 2020

Conversation

creativecreatorormaybenot
Copy link
Contributor

@Ahmadre Just want to point out that it is not guaranteed that there will be no breaking changes until 1.0.0. The Pub versioning would allow breaking changes when upgrading any x version in 0.x.y+z or x.y.z when x > 1.

It is correct that there was no breaking change for wakelock 0.2.0 (changelog) - only deprecations. However, I would probably want to remove the deprecations at some point.


About the cupertino_icons change: the caret syntax is identical in that case and the preferred syntax. See https://dart.dev/tools/pub/dependencies#caret-syntax.

@nstrelow nstrelow requested a review from Ahmadre November 11, 2020 14:18
@nstrelow
Copy link
Collaborator

Nice, what about also setting videoplayer to minimum of 0.11 ?
to have the speed stuff?

https://pub.dev/packages/video_player/changelog#0110

@creativecreatorormaybenot
Copy link
Contributor Author

@nstrelow Good point 👍 We can actually use ^1.0.0 now for video player as well (given how the dependencies allowed that previously anyway).

@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 11, 2020

@creativecreatorormaybenot sure let's do that but why did you downgrade wakelock? We need the latest wakelock for web support. After that this can be merged

@nstrelow
Copy link
Collaborator

Would that break anybodies setup?
e.g. using a package, which restricts to before 1.0.0?

I would feel better if we generally specify the lowest supported number. But looking at all the fixes until 1.0.0, I am fine with making this a requirement

@nstrelow
Copy link
Collaborator

nstrelow commented Nov 11, 2020

@Ahmadre Newest wakelock is 0.2.1+1

According to semver.org everything before 1.0.0, so 0.x.y can include breaking changes.

Usually only bigger publisher such as google care about that. But ideally setting it to <0.3.0, will make it so it does not break, should there be breaking changes for 0.3.0.

And then we can upgrade the breaking change or just the package when we want to and everybody still can use chewie like it is.

@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 11, 2020

Would that break anybodies setup?

e.g. using a package, which restricts to before 1.0.0?

I would feel better if we generally specify the lowest supported number. But looking at all the fixes until 1.0.0, I am fine with making this a requirement

Yeah sure let's also do ^0.2.1+1 for wakelock :)

@creativecreatorormaybenot
Copy link
Contributor Author

The dependencies should be fine like this.

wakelock might go to 1.0.0 when we have support for all platforms and it looks like the API is in a good state.

@nstrelow nstrelow merged commit fb6a409 into fluttercommunity:master Nov 11, 2020
@nstrelow
Copy link
Collaborator

Great thanks!

@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 11, 2020

Great thanks!

Thank you guys for this merge 🙏

@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 11, 2020

Alright guys, new version is online: Version

Thanks all :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants