-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependencies #395
Fix dependencies #395
Conversation
Nice, what about also setting videoplayer to minimum of 0.11 ? |
@nstrelow Good point 👍 We can actually use |
@creativecreatorormaybenot sure let's do that but why did you downgrade wakelock? We need the latest wakelock for web support. After that this can be merged |
Would that break anybodies setup? I would feel better if we generally specify the lowest supported number. But looking at all the fixes until 1.0.0, I am fine with making this a requirement |
@Ahmadre Newest wakelock is 0.2.1+1 According to semver.org everything before 1.0.0, so 0.x.y can include breaking changes. Usually only bigger publisher such as google care about that. But ideally setting it to <0.3.0, will make it so it does not break, should there be breaking changes for 0.3.0. And then we can upgrade the breaking change or just the package when we want to and everybody still can use chewie like it is. |
Yeah sure let's also do |
The dependencies should be fine like this.
|
Great thanks! |
Thank you guys for this merge 🙏 |
@Ahmadre Just want to point out that it is not guaranteed that there will be no breaking changes until
1.0.0
. The Pub versioning would allow breaking changes when upgrading any x version in0.x.y+z
orx.y.z
whenx > 1
.It is correct that there was no breaking change for
wakelock 0.2.0
(changelog) - only deprecations. However, I would probably want to remove the deprecations at some point.About the
cupertino_icons
change: the caret syntax is identical in that case and the preferred syntax. See https://dart.dev/tools/pub/dependencies#caret-syntax.