Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows XP target support #339

Closed
briansmith opened this issue Nov 8, 2016 · 2 comments
Closed

Add Windows XP target support #339

briansmith opened this issue Nov 8, 2016 · 2 comments

Comments

@briansmith
Copy link
Owner

[It's not clear that any ring users actually need XP support. Unless/until it is clear that it is needed, we should avoid adding it. I'm filing this issue here to keep track of what I know about what would be required for XP support.]

Rust only supports Vista and later in "tier 1." However, Firefox and maybe some other Rust applications do target Windows XP, and there are some hacks in libstd to make this partially work.

ring uses lazy_static and it's likely that lazy_static doesn't work correctly on XP because XP probably doesn't have the necessary concurrency primitives.

Also, we'd need to build the C & C++ code using the v140_xp toolchain.

I filed rust-lang/rust#37638 to get the Rust toolchain to support optionally enabling XP support in a consistent fashion throughout the ecosystem. If we implement this in the meantime, we could add a "windows-xp" feature to ring that is off-by-default, and which can be enabled by the application if they want to target XP too.

The hard part of this project is getting test coverage. We'd need to do it in a VM and can't use AppVeyor, since it doesn't support XP.

@briansmith
Copy link
Owner Author

Closing this since nobody seems to want it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant