Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher can't access files even with storage permission #9

Closed
TheoIsDumb opened this issue Jul 28, 2024 · 9 comments
Closed

Launcher can't access files even with storage permission #9

TheoIsDumb opened this issue Jul 28, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@TheoIsDumb
Copy link

Description

I have allowed the storage permission but Bridge can't seem to access the files.
The projection selection popup says 'This directory is empty'.
And creating new directories doesn't work.

But if I click 'Use this directory', Bridge main screen displays the following error: 'Bridge does not have permission to read the requested file.'

Screenshots

1722161359977
1722161359945

Affected App Version

0.0.3alpha

Operating System

Android 10 (MIUI 12.0.19)

Device Model

POCO C3 (angelicain)

@theothertored theothertored added the bug Something isn't working label Jul 29, 2024
@theothertored
Copy link
Member

This is most likely due to improperly checking perms on Android 10 (it has both scoped storage and regular storage without the "manage external storage" permission). I'll publish a quick fix in a sec.

@theothertored
Copy link
Member

Please update to this version and let me know if it fixed the problem.
https://github.com/bridgelauncher/launcher/releases/tag/v0.0.4-alpha

@TheoIsDumb
Copy link
Author

TheoIsDumb commented Jul 29, 2024

@theothertored it works! thank you so much, sir! 🫡

how can i return the favor? is it possible to donate to you? i don't have much right now, but i'll give you what i have.

@TheoIsDumb
Copy link
Author

By the way, I have a little doubt: I looked into the commits to see what you changed to make this permission thing work (I prolly won't understand it anyway), but I don't see any new commits, but you made a new release. How were you able to do that? I have no idea about how Android dev works.

@theothertored
Copy link
Member

theothertored commented Jul 30, 2024

is it possible to donate to you?

No, I don't wanna dox myself. Maybe at some point, when I finally get around to figuring out crypto.

I don't see any new commits, but you made a new release.

That's bad source control on my part, the fix is (if I recall correctly) a 1 line change (<= to < for checking the Android version to determine whether to use regular storage perms or the external storage manager perm) which I did quickly for someone on the Discord server. I have an giant rework of the entire app in my working folder, and instead of making a separate branch I just stashed my work, did the fix, built the APK, sent it, then undone the fix because I changed permission checking in the rework anyway and didn't wanna deal with merging. Now I just published the same APK as a new release ASAP.

I should split master from the rework branch, reimplement the fix, delete this release and upload a new one so you can actually build the same APK from the source in the repo, sorry for that, I'll ping you in this issue when I get around to it.

@theothertored
Copy link
Member

@TheoIsDumb
Copy link
Author

@theothertored hey, thank you, brother!

btw, i made a theme for bridge launcher. it's pretty barebones, but i've been using it for a long time.
please do check it out: https://github.com/theoisdumb/launch2

@theothertored
Copy link
Member

@TheoIsDumb cool design, very heartwarming to see Bridge getting some use :)
I like the status bar changing its foreground colour as the video changes, I wonder if that's hardcoded, built into Android or something custom?

@TheoIsDumb
Copy link
Author

@theothertored thanks! btw the color changing is built into android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants