We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Here https://github.com/bridgetownrb/node-runner/blob/master/lib/node_runner.js#L3
We have wrapper try-catch block. But is there any specific reason why Promise.resolve() doesn't have catch clause?
try-catch
Promise.resolve()
catch
The text was updated successfully, but these errors were encountered:
@aspirisen Honestly not sure! What should happen in a catch clause here? 🤔
Sorry, something went wrong.
@jaredcwhite I think it should have same stdout log
stdout
process.stdout.write(JSON.stringify(['err', '' + err, err.stack]))
Because func call is not awaited then try catch block doesn't handle the error
func
awaited
With await
await
With catch clause
@aspirisen OK, that makes sense to me. Could you make that fix in a PR and I'll merge? TY!
No branches or pull requests
Here https://github.com/bridgetownrb/node-runner/blob/master/lib/node_runner.js#L3
We have wrapper
try-catch
block.But is there any specific reason why
Promise.resolve()
doesn't havecatch
clause?The text was updated successfully, but these errors were encountered: