Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running with no args prints error #22

Open
tomsaleeba opened this issue May 10, 2018 · 0 comments
Open

Running with no args prints error #22

tomsaleeba opened this issue May 10, 2018 · 0 comments

Comments

@tomsaleeba
Copy link
Contributor

Steps:

  1. use fast-nvm-fish 2a5ad55
  2. run nvm (with no args)

Expected:
The help message for nvm is shown.

Actual:
The warning from this script is shown (not the issue here) and an error message from the test command:

nvm-fast: at least one argument is required
test: Missing argument at index 2

I think if you show that warning message, the script should halt because continuing without something the script states it needs is heading for failure.

Alternatively, don't worry about printing a warning and instead, set the default arg to --help and let the script continue. I'm a fan of this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant