Github Actions isn't pushing correct docker image tags

[thomas-anderson-bsl]

Our Github Actions aren't pushing the correct docker image tag. See https://github.com/brightsparklabs/appcli/runs/5280840366?check_suite_focus=true

It is pushing docker push brightsparklabs/appcli:1d1642d without the git tag information.

The tag is being generated by git describe --always --dirty in Makefile: https://github.com/brightsparklabs/appcli/blob/develop/Makefile#L14

I think this is related to some weird git pull as part of the 'checkout' action. May need to set fetch-depth: 0. See https://github.com/actions/checkout#fetch-all-history-for-all-tags-and-branches
actions/checkout#290
actions/checkout#250

[thomas-anderson-bsl]

We should be able to fix and test this somewhat locally by:

• apply relevant fix
• create a new Make target which prints APP_VERSION
• use https://github.com/nektos/act to run that Make target to determine if it's fixed

and iterate as required.

[thomas-anderson-bsl]

Pretty sure this issue is related to actions/checkout#240

[thomas-anderson-bsl]

Testing with nektos/act isn't proving to be fruitful, as I don't think it's actually pulling the repo (it's only acting on the local git)

[thomas-anderson-bsl]

Fixed with 32e37dd