-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Query log" for a pool #4034
Comments
The user that originally requested this feature thought of it again after we showed them a demo of the Remote Queries feature. In that case the queries are stored in a pool as a result of an action of the user. But they recognized that it would not be difficult to extend this by just storing all queries executed in such a pool along with the additional metadata described above. A SQL user, they also thought of https://www.postgresql.org/docs/current/sql-explain.html as something to mimic. |
Short of the deluxe "explain"-style treatment described above, linked PR #4385 provides an initial baby step by including the Zed query in the lake log at debug level. The following shows this at Zed commit bbc9c4d. Starting the lake:
Running a query from another shell:
How it looks in the Zed lake log:
|
A community user recently asked:
Indeed, the architecture easily supports this, and it's something for which the Dev team has also recognized the need. Beyond mere convenience for users that want to see history, an internal motivation is that zync represents the first tool other than the Brim/Zui app that generates lots of queries that are opaque to the user, e.g., different YAML files might cause the generation of different queries, and these will perform differently. A "query log" would help here by saving such things as:
This data could then be fed into a Pareto chart that would help us understand which queries most need help from enhancements in the query optimizer.
The text was updated successfully, but these errors were encountered: