improve UX for metadata queries #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the UX for metadata queries by using the metadata type name to distinguish between commit-level queries and pool-level queries rather than requiring the presence of an @Branch commit tag for commit-level queries. This way you can query the objects on the main branch of a pool without specifying @main. We also fixed a bug in the optimization logic where the layout of metadata queries was presumed to be the same layout of the pool. The fix is to presume the layout of metadata queries is unknown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the UX for metadata queries by using the metadata type name to distinguish between commit-level queries and pool-level queries rather than requiring the presence of an
@branchcommit tag for commit-level queries. This way you can query the objects on the main branch of a pool without specifying@main. We also fixed a bug in the optimization logic where the layout of metadata queries was presumed to be the same layout of the pool. The fix is to presume the layout of metadata queries is unknown.