Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

Windows: fix calc_next_rotate() #29

Merged
merged 1 commit into from
May 28, 2020
Merged

Conversation

nwt
Copy link
Member

@nwt nwt commented May 27, 2020

This should fix #28.

I tried to avoid adding strptime.c by doing something like https://stackoverflow.com/a/33542189, but it failed on "0:00" because libstdc++'s std::get_time() requires two input characters for %H.

@nwt nwt requested a review from a team May 27, 2020 23:35
Copy link

@alfred-landrum alfred-landrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open a PR against the Brim repo to add this license to the acknowledgements file there.

alfred-landrum added a commit to brimdata/zui that referenced this pull request May 27, 2020
@nwt nwt merged commit 29c8133 into master May 28, 2020
@nwt nwt deleted the windows-fix-calc_next_rotate branch May 28, 2020 00:22
alfred-landrum added a commit to brimdata/zui that referenced this pull request May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate Zeek warning: calc_next_rotate(): can't parse rotation base time
2 participants