Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny duration shown as "Not available" in correlations view #3101

Closed
philrz opened this issue Jun 18, 2024 · 1 comment · Fixed by #3119
Closed

Tiny duration shown as "Not available" in correlations view #3101

philrz opened this issue Jun 18, 2024 · 1 comment · Fixed by #3119
Assignees
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented Jun 18, 2024

Repro is with Zui commit b4ed51d.

The attached test data conn.log.gz contains two Zeek conn records. As shown in the attached video, when the duration value is large, the "Duration" line printed below the correlations view shows an accurate approximation of the the value (specifically, 21 minutes 9 seconds whereas the full-precision original value was 21m9.512465s). However, for the other record where the original value is 1us, the value shown below the correlations view is Not available, which is incorrect.

Repro.mp4

I poked through the code and I see the math that's triggering the problem, but I'm not certain yet of the best fix.

@philrz philrz added the bug Something isn't working label Jun 18, 2024
@philrz philrz self-assigned this Jun 18, 2024
@philrz philrz transferred this issue from brimdata/super Jun 18, 2024
@philrz philrz assigned jameskerr and unassigned philrz Jun 20, 2024
@philrz
Copy link
Contributor Author

philrz commented Jul 2, 2024

Verified in Zui commit 6a90407.

As shown in the attached video, now when the conn record with 1us duration is clicked, the text below the correlation accurately says "less than 1 millisecond" rather than the prior "Not available". Also, as noted in the linked PR #3119, the change also now shows durations in the range less than 1 second in whole milliseconds rather than as a fraction of seconds, and this is also shown.

Verify.mp4

Thanks @jameskerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants