From 8186547a72b8d4c722c09387fdd0a053c7d0b91d Mon Sep 17 00:00:00 2001
From: Brenden Matthews <github@brenden.brndn.io>
Date: Tue, 4 Jun 2024 13:49:45 -0400
Subject: [PATCH] Docker: only write to cache if creds available

---
 .github/scripts/docker-build.bash | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)

diff --git a/.github/scripts/docker-build.bash b/.github/scripts/docker-build.bash
index 7c60c6c39..4e34b972c 100755
--- a/.github/scripts/docker-build.bash
+++ b/.github/scripts/docker-build.bash
@@ -1,12 +1,18 @@
 #!/usr/bin/env bash
 set -ex
 
-DOCKERHUB_USERNAME="${DOCKERHUB_USERNAME:-conky}"
-DOCKERHUB_IMAGE_ID=$DOCKERHUB_USERNAME/$IMAGE_NAME
+DH_USERNAME="${DOCKERHUB_USERNAME:-conky}"
+DOCKERHUB_IMAGE_ID=$DH_USERNAME/$IMAGE_NAME
 
 # Change all uppercase to lowercase
 DOCKERHUB_IMAGE_ID=$(echo $DOCKERHUB_IMAGE_ID | tr '[A-Z]' '[a-z]')
 
+# Only build amd64 on PRs, build all platforms on main. The arm builds
+# take far too long.
+image_platforms="--platform linux/amd64"
+push_image=""
+cache_tag="pr-cache"
+
 image_tags=()
 
 # Strip git ref prefix from version
@@ -24,12 +30,6 @@ if [[ "$RELEASE" == ON ]]; then
     image_tags+=("--tag" "$DOCKERHUB_IMAGE_ID:latest")
 fi
 
-# Only build amd64 on PRs, build all platforms on main. The arm builds
-# take far too long.
-image_platforms="--platform linux/amd64"
-push_image=""
-cache_tag="pr-cache"
-
 # Only push on main
 if [[ "$GITHUB_REF" == refs/heads/main ]]; then
     push_image="--push"
@@ -37,10 +37,17 @@ if [[ "$GITHUB_REF" == refs/heads/main ]]; then
     cache_tag="main-cache"
 fi
 
+# Only write to cache if credentials are available
+if [[ -z "$DOCKERHUB_USERNAME" ]]; then
+    write_cache=""
+else
+    write_cache="--cache-to=type=registry,ref=$DOCKERHUB_IMAGE_ID:$cache_tag,mode=max"
+fi
+
 docker buildx build \
     ${push_image} \
     ${image_platforms} \
-    --cache-from=type=registry,ref=$DOCKERHUB_USERNAME/$IMAGE_NAME:$cache_tag \
-    --cache-to=type=registry,ref=$DOCKERHUB_USERNAME/$IMAGE_NAME:$cache_tag,mode=max \
+    --cache-from=type=registry,ref=$DOCKERHUB_IMAGE_ID:$cache_tag \
+    ${write_cache} \
     "${image_tags[@]}" \
     .