Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: conky 1.20.2 fails to build with specific options combination #1873

Closed
iDarkTemplar opened this issue Apr 29, 2024 · 3 comments · Fixed by #1874
Closed

[Bug]: conky 1.20.2 fails to build with specific options combination #1873

iDarkTemplar opened this issue Apr 29, 2024 · 3 comments · Fixed by #1874
Labels
bug Bug report or bug fix PR build system Issues and PRs related to build system (CMake) and process lua Issue or PR related to Lua code

Comments

@iDarkTemplar
Copy link
Contributor

What happened?

When trying to update conky to 1.20.2 with my build options, it fails to build.
Relevant cmake build options:
-DBUILD_IMLIB2=yes -DBUILD_LUA_CAIRO=no -DBUILD_LUA_IMLIB2=yes

Full cmake options:
cmake -C /var/tmp/portage/app-admin/conky-1.20.2/work/conky-1.20.2_build/gentoo_common_config.cmake -G Ninja -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_ARGB=yes -DBUILD_X11=yes -DBUILD_XDAMAGE=yes -DBUILD_XDBE=yes -DBUILD_XFIXES=yes -DBUILD_XSHAPE=yes -DBUILD_XINPUT=yes -DBUILD_MOUSE_EVENTS=yes -DOWN_WINDOW=yes -DBUILD_APCUPSD=no -DBUILD_AUDACIOUS=no -DBUILD_BUILTIN_CONFIG=yes -DBUILD_CMUS=no -DBUILD_CURL=no -DBUILD_DOCS=no -DBUILD_EXTRAS=yes -DBUILD_HDDTEMP=no -DBUILD_HTTP=no -DBUILD_I18N=yes -DBUILD_IBM=no -DBUILD_ICAL=no -DBUILD_ICONV=yes -DBUILD_IMLIB2=yes -DBUILD_INTEL_BACKLIGHT=no -DBUILD_IOSTATS=yes -DBUILD_IPV6=yes -DBUILD_IRC=no -DBUILD_JOURNAL=no -DBUILD_LUA_CAIRO=no -DBUILD_LUA_IMLIB2=yes -DBUILD_LUA_RSVG=no -DBUILD_MATH=yes -DBUILD_MOC=no -DBUILD_MPD=no -DBUILD_MYSQL=no -DBUILD_NCURSES=yes -DBUILD_NVIDIA=no -DBUILD_OLD_CONFIG=yes -DBUILD_PORT_MONITORS=yes -DBUILD_PULSEAUDIO=yes -DBUILD_RSS=no -DBUILD_TESTS=no -DBUILD_WAYLAND=yes -DBUILD_WLAN=yes -DBUILD_XFT=yes -DBUILD_XINERAMA=yes -DBUILD_XMMS2=no -DDOC_PATH=/usr/share/doc/conky-1.20.2 -DMAINTAINER_MODE=no -DRELEASE=yes -DPython3_EXECUTABLE=/usr/bin/python3.11 -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_TOOLCHAIN_FILE=/var/tmp/portage/app-admin/conky-1.20.2/work/conky-1.20.2_build/gentoo_toolchain.cmake /var/tmp/portage/app-admin/conky-1.20.2/work/conky-1.20.2

Build error:
�[31mFAILED: �[0mlua/CMakeFiles/conky-cairo_imlib2_helper.dir/libcairo_imlib2_helper.cc.o
/usr/bin/x86_64-pc-linux-gnu-g++ -DTOLUA_RELEASE -D_LARGEFILE64_SOURCE -D_POSIX_C_SOURCE=200809L -Dconky_cairo_imlib2_helper_EXPORTS -I/var/tmp/portage/app-admin/conky-1.20.2/work/conky-1.20.2/3rdparty/toluapp/include -I/usr/include/lua5.4 -I/var/tmp/portage/app-admin/conky-1.20.2/work/conky-1.20.2_build -I/var/tmp/portage/app-admin/conky-1.20.2/work/conky-1.20.2/lua -I/var/tmp/portage/app-admin/conky-1.20.2/work/conky-1.20.2/src -march=alderlake -mtune=alderlake -mabm -mno-cldemote -mno-kl -mno-sgx -mno-widekl -mshstk --param=l1-cache-line-size=64 --param=l1-cache-size=32 --param=l2-cache-size=30720 -O2 -pipe -fwrapv -std=c++17 -fPIC -Wno-unused-parameter -Wno-cast-qual -Wno-error=pedantic -MD -MT lua/CMakeFiles/conky-cairo_imlib2_helper.dir/libcairo_imlib2_helper.cc.o -MF lua/CMakeFiles/conky-cairo_imlib2_helper.dir/libcairo_imlib2_helper.cc.o.d -o lua/CMakeFiles/conky-cairo_imlib2_helper.dir/libcairo_imlib2_helper.cc.o -c /var/tmp/portage/app-admin/conky-1.20.2/work/conky-1.20.2_build/lua/libcairo_imlib2_helper.cc
/var/tmp/portage/app-admin/conky-1.20.2/work/conky-1.20.2_build/lua/libcairo_imlib2_helper.cc:16:10: fatal error: cairo.h: No such file or directory
16 | #include <cairo.h>
| ^~~~~~~~~
compilation terminated.

It looks like conky tries to build helper which depends both on imlib2 and cairo when imlib2 is enabled and cairo is disabled, and fails. I suspect that it was broken in commit 45500b1. Conky 1.20.1 builds fine with same options.

Version

1.20.2

Which OS/distro are you seeing the problem on?

Gentoo

Conky config

No response

Stack trace

No response

Relevant log output

No response

@iDarkTemplar iDarkTemplar added bug Bug report or bug fix PR triage Issue that hasn't been verified labels Apr 29, 2024
@iDarkTemplar iDarkTemplar changed the title [Bug]: lua 1.20.2 fails to build with specific options combination [Bug]: conky 1.20.2 fails to build with specific options combination Apr 29, 2024
@Caellian
Copy link
Collaborator

Can you try fix/cairo-imlib2-helper-dep and let me know whether it's fixed by that branch?

@Caellian Caellian reopened this Apr 29, 2024
@iDarkTemplar
Copy link
Contributor Author

Can you try fix/cairo-imlib2-helper-dep and let me know whether it's fixed by that branch?

Yes, works for me. Thanks!

@Caellian Caellian linked a pull request Apr 29, 2024 that will close this issue
@Caellian Caellian added build system Issues and PRs related to build system (CMake) and process lua Issue or PR related to Lua code and removed triage Issue that hasn't been verified labels Apr 29, 2024
@Caellian
Copy link
Collaborator

Cool, then this issue will close when PR is approved and merged. Thanks for quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report or bug fix PR build system Issues and PRs related to build system (CMake) and process lua Issue or PR related to Lua code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants