Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using @react-native-community/cli instead of react-native-cli #204

Closed
zhigang1992 opened this issue Dec 3, 2019 · 6 comments · Fixed by #421
Closed

Using @react-native-community/cli instead of react-native-cli #204

zhigang1992 opened this issue Dec 3, 2019 · 6 comments · Fixed by #421
Assignees
Labels
enhancement New feature or request

Comments

@zhigang1992
Copy link

zhigang1992 commented Dec 3, 2019

@react-native-community/cli

is the official next version of react-native-cli

https://github.com/react-native-community/cli

There are some differences with them.

@brodycj brodycj added enhancement New feature or request help wanted Extra attention is needed info-needed labels Dec 3, 2019
@zhigang1992 zhigang1992 changed the title Using @react-native/cli instead of react-native-cli Using @react-native-community/cli instead of react-native-cli Dec 3, 2019
@brodycj
Copy link
Owner

brodycj commented Dec 3, 2019

Definitely an interesting idea.

From https://github.com/react-native-community/cli#using-npx-recommended and https://github.com/facebook/react-native/blob/0.61-stable/package.json#L4 I start to wonder why not just use cli.js from the react-native package itself?

@zhigang1992
Copy link
Author

Yeah, it'd be awesome if we can eliminate this external dependency, and don't have to worry about them getting out of sync.

@brodycj brodycj self-assigned this Feb 12, 2020
@brodycj brodycj removed the help wanted Extra attention is needed label Feb 12, 2020
@brodycj

This comment has been minimized.

@brodycj brodycj pinned this issue Mar 2, 2020
@brodycj
Copy link
Owner

brodycj commented Mar 2, 2020

This issue is now pinned in first place, I hope to get it resolved in the near future.

And I would definitely favor this idea over using npx as proposed in issue #265 & PR #267.

@brodycj
Copy link
Owner

brodycj commented Mar 4, 2020

I would like to clarify for the sake of some others that this project would use @react-native-community/cli by adding it to its package dependencies, as they documented here: https://github.com/react-native-community/cli#about

@brodycj
Copy link
Owner

brodycj commented Mar 4, 2020

The one major drawback of this idea is that @react-native-community/cli seemed to be a heavy dependency when I tried adding it in my workarea. I think the ideal solution would be to somehow render the example from the template in react-native itself and then use Yarn and pod to install its dependencies.

Any alternatives from the user community would be welcome for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment