Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Bundle 'plugin', not # Bundle: plugin #28

Open
bronson opened this issue Oct 15, 2011 · 2 comments
Open

use Bundle 'plugin', not # Bundle: plugin #28

bronson opened this issue Oct 15, 2011 · 2 comments

Comments

@bronson
Copy link
Owner

bronson commented Oct 15, 2011

Only support this style of directive:

Bundle 'jQuery'                                  # https://github.com/vim-scripts/jQuery
Bundle 'scrooloose/nerdtree'                     # https://github.com/scrooloose/nerdtree
Bundle 'git://git.wincent.com/command-t.git'     # Full URL to the repo to clone

Don't allow putting them in comments anymore like this:

" Bundle: jQuery                                  # https://github.com/vim-scripts/jQuery
" Bundle: scrooloose/nerdtree                     # https://github.com/scrooloose/nerdtree
" Bundle: git://git.wincent.com/command-t.git     # Full URL to the repo to clone

Supporting both is too confusing.

@bronson
Copy link
Owner Author

bronson commented Nov 18, 2011

Also make sure that trailing comments (either " or #) don't screw it up.

@sukima
Copy link

sukima commented Dec 2, 2011

So I understand two formats is confusing but I'm trying to understand why the non commented version is better. I realize it's the syntax for some other plugin but what if you never use this other plugin? Do you have to place some hack in your vimrc to prevent a syntax error on the word "Bundle"? I think having this in a comment is more appropriate.

Have you considered using the Bundle '*' approach with an optional comment? This would allow only one regex and one syntax but allow those who don't use the hack to just comment the line with '"'

" Bundle 'foo' #bar
Bundle 'foo' #bar
match /Bundle\s+'\(.*\)'/i  <-- Works with *both* forms and needs only _one_ parsing algorythm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants