Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it's wrong to set charset to UTF-8 for text #30

Closed
kaven276 opened this issue Apr 28, 2012 · 2 comments
Closed

it's wrong to set charset to UTF-8 for text #30

kaven276 opened this issue Apr 28, 2012 · 2 comments

Comments

@kaven276
Copy link

In mime.js

charsets: {
   lookup: function (mimeType, fallback) {
     // Assume text types are utf8.  Modify mime logic as needed.
     return (/^text\//).test(mimeType) ? 'UTF-8' : fallback;
   }
 }

I have many static file that's not utf-8 encoded, when access from web server like connect, the browser display mess.

If leave charset empty, the browser will itself detect charset of the content, and display correctly.

@broofa
Copy link
Owner

broofa commented Apr 29, 2012

Are you saying Connect shouldn't be returning a charset? If so, then please file a bug with that project. Otherwise, what specifically are you suggesting be changed here?

@broofa
Copy link
Owner

broofa commented May 29, 2012

No followup from @kaven276. Closing

@broofa broofa closed this as completed May 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants