Do not attempt to match newline characters #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Thanks for catching this. This package is derived from the Haskell language package, so I wasn't sure exactly how correct it'd be. I'll try this out on my machine and merge it if everything's fine! |
|
I've submitted pretty much the same PR to upstream Haskell as well :). |
|
@paxromana96 just a little reminder about this PR :). It's the last one waiting to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all \n end matches with $. The two are nearly identical, with the only difference being that $ does not create a zero-width match at the end of the line. These changes are mainly required due to atom/first-mate#100, as newlines are no longer added to the last line of the file. Therefore, this change is simply a backwards-compatible change to ensure that language-frege continues working as before on Atom 1.22+.
I hope I did the whole grammar generation correctly!
/cc @Ingramz
Refs atom/atom#15729