Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 to the testing #696

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 7, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #696 (176422f) into main (eed61c3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #696   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files          30       30           
  Lines        1028     1028           
  Branches      197      221   +24     
=======================================
  Hits         1015     1015           
  Partials       13       13           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Owner

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@browniebroke browniebroke merged commit 2295357 into browniebroke:main Nov 7, 2022
@cclauss cclauss deleted the patch-1 branch November 7, 2022 13:13
@cclauss
Copy link
Contributor Author

cclauss commented Nov 8, 2022

Do the Python 3.11 performance gains matter for the process of using this tool?

@browniebroke
Copy link
Owner

Probably... Although I haven't profiled where the bottlenecks are, my guess is that it might be a mix of IO and CPU.

If you're concerned about speed and don't need Python 3.7, I would encourage you to check out django-upgrade which is much faster and has more features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants