Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error #243

Closed
iruzevic opened this issue Apr 11, 2018 · 1 comment
Closed

Fatal error #243

iruzevic opened this issue Apr 11, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@iruzevic
Copy link

Hy I have tried to load browscap using composer and followed the readme and i got

Xdebug: Fatal error: Uncaught ArgumentCountError: Too few arguments to function BrowscapPHP\Browscap::__construct(), 0 passed in

@mimmi20 mimmi20 added the bug label Apr 11, 2018
@alex-nesterov
Copy link

alex-nesterov commented Apr 19, 2018

so now browscap requires 2 params, but readme not updated.

/**
     * Browscap constructor.
     *
     * @param \Psr\SimpleCache\CacheInterface  $cache
     * @param LoggerInterface $logger
     */
    public function __construct(CacheInterface $cache, LoggerInterface $logger)
    {
        $this->cache = new BrowscapCache($cache, $logger);
        $this->logger = $logger;

        $this->formatter = new Formatter\PhpGetBrowser();
    }

This was referenced Apr 20, 2018
@asgrim asgrim assigned asgrim and mimmi20 and unassigned asgrim Apr 20, 2018
@asgrim asgrim added this to the 4.2.0 milestone Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants