Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis CI builds, update dependencies, and update list of as-yet unimplemented functions #200

Closed
wants to merge 4 commits into from

Conversation

rawr51919
Copy link

@rawr51919 rawr51919 commented Jan 24, 2021

Fixes #199
Fixes #196
Fixes #194
Fixes #192

@rawr51919 rawr51919 changed the title Fix deprecation warnings and update deps Fix Travis CI builds and update dependencies Jan 24, 2021
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. should be a patch update

@rawr51919
Copy link
Author

rawr51919 commented Jan 24, 2021

Minor note @ljharb
Node 0.1x builds broke because https://github.com/crypto-browserify/publicEncrypt grabs a later version of parse-asn1 than what was originally used for the last build 3 years ago. This later version is incompatible with node 0.1x due to erroring on the unit tests there.

@ljharb
Copy link
Member

ljharb commented Jan 24, 2021

0.1? Or 0.10?

@rawr51919
Copy link
Author

0.1? Or 0.10?

0.11/0.12

@rawr51919
Copy link
Author

rawr51919 commented Jan 24, 2021

@ljharb
I figured out what was erroring out the build originally for Saucelabs. Some of the ports weren't forwarded for some strange reason

Error: connection refused: localtunnel.me:41870 (check your firewall settings)
Error: connection refused: localtunnel.me:34242 (check your firewall settings)
Error: connection refused: localtunnel.me:35354 (check your firewall settings)

These are from the last build from 3 years ago. Perhaps trying to fix these would be worth your while

@ljharb
Copy link
Member

ljharb commented Jan 24, 2021

gotcha, but they’ll pass now? If not, can we pin parse-asn1 so they do?

@rawr51919
Copy link
Author

rawr51919 commented Jan 24, 2021

gotcha, but they’ll pass now?

If of course you have those issues fixed, then yes, this will just fine (see my last few posts here for what issues I'm talking about)

@rawr51919
Copy link
Author

Pretty much, if the parse-asn1 issue is fixed along with those connection refused issues, this will pass Travis CI

@rawr51919
Copy link
Author

rawr51919 commented Jan 24, 2021

gotcha, but they’ll pass now? If not, can we pin parse-asn1 so they do?

Yep! 5.1.0 iirc is the last version that worked

@rawr51919
Copy link
Author

Any progress updates on this so far? Has the Saucelabs stuff been figured out yet?

@rawr51919
Copy link
Author

Looks like this fixes more than I first realized.

@rawr51919 rawr51919 changed the title Fix Travis CI builds and update dependencies Fix Travis CI builds, update dependencies, and update list of as-yet unimplemented functions Feb 2, 2021
This was referenced Feb 2, 2021
@cwc972135903
Copy link

do you how to implement the generateKeyPair

Copy link

@markhughes markhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

randomFill and randomFillSync are implemented :)

@@ -31,6 +31,15 @@ Here is the subset that is currently implemented:
these features from node's `crypto` are still unimplemented.

* createCredentials
* getCurves
* randomFill
* randomFillSync

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

randomFill and randomFillSync are implemented, we can remove this from the README

;['createCredentials',
'getCurves',
'randomFill',
'randomFillSync',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

randomFill and randomFillSync are implemented, we can remove this from the error message array

@rawr51919 rawr51919 closed this by deleting the head repository Aug 12, 2023
@rawr51919
Copy link
Author

this PR will return, eventually, just was cleaning out old repos, may merge this and #201 together into one PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when try to use Diffie-Hellman properties Security vulnerability in browserify-sign
4 participants