use relative path for process/browser.js

[Trott]

Trying to achieve the same goal as #31 of omitting absolute paths from the output file that could reveal more than one wants about the builder's setup (e.g., the username they use to login on their machine).

• Not quite the one-line change @substack suggested it might be, but maybe three lines is close enough?
• Only tested with npm test and by using it on my own projects, so not sure if I'm missing use cases?
• Removal of whitespace from empty lines courtesy of my editor. Happy to resubmit without the whitespace removal if, you know, even minor stuff like that should be omitted as unrelated.

[ghost]

This is a really spammy patch with the whitespace. I didn't want to merge #31 because it didn't have an associated failing test case. I really don't want to just take people's word for it that their patch fixes an issue, I want failing tests.

[Trott]

I've added a test (that fails for current master, of course) and restored the original white space.

Diff to master of version with a simple test: https://github.com/Trott/insert-module-globals/compare/relative-path-take-2-er-3?expand=1

If that test is Doing It Wrong, I also did a Probably-Doing-It-Wrong-Too attempt to emulate the style of the pre-existing tests. Diff vs. master: https://github.com/Trott/insert-module-globals/compare/relative-path?expand=1

Would you consider either of these? Or am I just wasting everyone's time and I really need to stop right now?

[ghost]

Thanks for the test! That is really helpful in verifying that these patches behave as advertised. Is it possible to get the patch without the whitespace spam in the diffs?

[Trott]

Sure. I'll submit it as a different PR. Hope that's OK.