Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserveSymlink options not supported #122

Closed
magicdawn opened this issue Mar 25, 2017 · 2 comments
Closed

preserveSymlink options not supported #122

magicdawn opened this issue Mar 25, 2017 · 2 comments

Comments

@magicdawn
Copy link

see

I add a sync version, but the async callback version is too complicated for me 😂
https://github.com/magicdawn/node-resolve/commit/8bfeeccaf66d33c530ed2e373ab2138621e9500f
@magicdawn magicdawn mentioned this issue Mar 25, 2017
Closed
@ljharb
Copy link
Member

ljharb commented Mar 25, 2017

This seems to have been added in node v6.3.0.

Based on your changes, it seems like since this module never calls fs.realPath, it's already preserving symlinks - what would be most helpful (more than your commit, which helps too) is failing sync and async test cases. With that, I could work on an implementation.

This was referenced Feb 17, 2018
Closed
Merged
@ljharb
Copy link
Member

ljharb commented Jun 17, 2018

resolve supports a preserveSymlinks option now; I'll be happy to reopen if that doesn't address this.

@ljharb ljharb closed this as completed Jun 17, 2018
@ljharb ljharb mentioned this issue Jun 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @magicdawn