Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduped files missing from subsequent bundles #143

Closed
ben-ng opened this issue Feb 21, 2015 · 4 comments
Closed

Deduped files missing from subsequent bundles #143

ben-ng opened this issue Feb 21, 2015 · 4 comments

Comments

@ben-ng
Copy link

ben-ng commented Feb 21, 2015

To reproduce: https://github.com/ben-ng/watchify-dedupe-bug

It seems like the first require is fine, but subsequent requires to duplicate files break after the first bundle.

I tried to figure out what was wrong (its a pretty big hinderance to development, not being able to live-reload) but couldn't get anything. Hopefully someone else has better luck!

@ghost
Copy link

ghost commented Feb 21, 2015

It might be the same issue as browserify/browserify#1101

@ben-ng
Copy link
Author

ben-ng commented Feb 21, 2015

Yes, that looks similar. Do you recommend the hotfix? Ive manually deduped my modules for now but thats a fragile temporary measure.

@ghost
Copy link

ghost commented Feb 21, 2015

The hotfix is ok for now. I've added the failing case you put together to the test suite to protect against regressions and in case somebody has a better fix in the future. Published upstream in browserify 9.0.3.

@ghost ghost closed this as completed Feb 21, 2015
@ben-ng
Copy link
Author

ben-ng commented Feb 21, 2015

Excellent! Have a good night.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant