This repository has been archived by the owner on May 27, 2019. It is now read-only.
Added titles to buttons for a better user experience #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximbaz
suggested changes
Mar 22, 2018
chrome/script.browserify.js
Outdated
| @@ -36,7 +36,7 @@ function view() { | |||
| } else if (logins.length > 0) { | |||
| results = logins.map(function(login) { | |||
| let selector = "button.login"; | |||
| let options = { onclick: getLoginData.bind(login) }; | |||
| let options = { onclick: getLoginData.bind(login), title: "Fill form" + (localStorage.getItem("autoSubmit") ? " and submit" : "") }; | |||
There was a problem hiding this comment.
could you change the code to access localStorage only once and store result in the variable, before the logins.map()?
Also, this doesn't really work if you change autosubmit to "yes", save, and then change back to "no".
It should be instead localStorage.getItem("autoSubmit") == "true"
maximbaz
approved these changes
Mar 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says is already :)