Allow configuring multiple custom password stores #237
Conversation
Known limitation: two password stores cannot have identical file names
What's the limitation causing this? Would adding a temporary prefix be a suitable workaround? |
pass/disk.go
Outdated
|
|
||
| for i, match := range allMatches { | ||
| // TODO this does not handle identical file names in multiple s.paths | ||
| item, err := filepath.Rel(path, match) |
There was a problem hiding this comment.
@erayd this is the cause of the limitation, it generates the entry name by cutting off the configured prefix. A better solution would need to account for multiple configured paths to make sure it cuts off as much as possible, but still keeping the resulting string unique among all paths.
There was a problem hiding this comment.
Mind if I open a PR against this branch with a proposed workaround?
pass/disk.go
Outdated
| continue | ||
| } | ||
| // TODO this does not handle identical file names in multiple s.paths | ||
| return f, err |
There was a problem hiding this comment.
And then here, when we receive an entry "github.com", the code is trying to guess, which password store it belongs to. Right now the code is simple, the first password store that contains "git.luolix.top.gpg" is the one 🙂
Rewrite to allow matches from multiple stores
|
Description updated, all limitations fixed. |
Mmm, the makefile is the same and I just ran This is the output when I run
|
|
That looks quite different - I just get this: |
| var fileNames []string | ||
| for _, entry := range entries { | ||
| fileNames = append(fileNames, strings.SplitN(entry, ":", 2)[1]) | ||
| } |
There was a problem hiding this comment.
@erayd you'll love this 🙂 Caught by a unit test, that suddenly started finding 10 entries instead of 1 for a search term "def" (which started to match store name "default")
There was a problem hiding this comment.
Nice catch :-).
I actually use the store name as part of my search fairly commonly, to distinguish between files in different stores that have otherwise identical names. However, I don't actually need that capability in the host app - having it in the "refine search" filter (which also includes the store name in searches) is enough for my use-case :-).
There was a problem hiding this comment.
Good point, until now I didn't even think to test how "refine search" behaves with store names, but I agree this is a very common use-case to refine by the store name. In fact, I'm used to that too, because I have both "work" and "personal" in the same password store, but now I can configure different browser profiles to use different subfolders and this reduces 99% of cases where I needed to refine - now I just press Enter 🙂
I had a few hours free, so I decided to play with implementing this feature.
I suggest reviewing the diff without whitespace changes.
The idea is to allow configuring multiple password stores in options, and even toggle them when needed:
A folder can be a path to a custom password store (#98), a path to a subdirectory of a password store (#34) or a path to gopass mount (#77).
Known limitations
Nothing left here 🙂
Fixed
1. It has to be an absolute path, no expansion of `~` or environment variables.Fixed by @erayd in #239
I didn't have time (and desire) to dynamically add/remove more lines for directories, so I pre-created 5 empty input lines. Because 5 should be enough for everyone 😄 I'm joking, but if you want to implement something fancier, please submit a new PR.
Current solution doesn't support having files with identical names. In other words, if you enable two password stores in the options:
And you have identically named files in both password stores, like this:
Only the first
git.luolix.top.gpgwill be seen by browserpass. Use checkbox in the extension options to temporarily disable password store that you don't need.However if the files are in different subfolders (like below), then it's fine:
Fixes #98
Fixes #34
Fixes #77