Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Incompatibility with Service Worker #53

Open
alejodiazg opened this issue May 21, 2017 · 3 comments
Open

Incompatibility with Service Worker #53

alejodiazg opened this issue May 21, 2017 · 3 comments
Labels

Comments

@alejodiazg
Copy link

HI, been using your library to send notifications to apps for a while, now Im implementing a js client with a service worker.

As referenced in this issue from firebaseJs firebase/quickstart-js#71

When sending in a notification the field notification this takes over and the custom handler does not trigger

Theres a way to call the notification field sent to firebase something else, or even skip it?

@brozot
Copy link
Owner

brozot commented Jul 26, 2017

Hello ,

Sorry for the late answer, I don't have lot of time for the support of this package the last months but normally in the future I should be more present.

I can't solve your issue now I have to reproduce it.

I'have planned to work on an update (released for august) of this package to include new features of FCM and Laravel, I will take a look to your issue for the next updade.

Best regards,

Nicolas

@brozot brozot added the bug label Jul 26, 2017
@alejodiazg
Copy link
Author

Thanks or the answer.

Reading the FCM documentation a bit more I saw that the expected or correct format for the notification varies, maybe giving more control will solve the issue, currently I cant check but as this is needed for or system I could help with a solution/testing

@YsightTechie
Copy link

Hello. Is there any update with this issue? I send notifications to browsers and to ios and android apps on the same channel. Because I set the "click_action" field of the notification to ".MainActivity" in order to set the intent on the Android, the browser always fails on the click of the notification at the lines below.

SWController.prototype.getWindowClient_ = function (url) { // Use URL to normalize the URL when comparing to windowClients. // This at least handles whether to include trailing slashes or not var parsedURL = new URL(url).href; <--- error line value of ".MainActivity"

Is there a plan to fix this soon? If not, do you have a work around that does not require different channels? Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants