Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phase out *mathspace mspace values #1962

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

dginev
Copy link
Collaborator

@dginev dginev commented Oct 10, 2022

Fixes #1801 .

Questions to @brucemiller :

  • Should we use the em units MathML Core recommends, instead of pt, so that spaces scale along with font-size?
  • Is the PR correct so far?

I can claim the current commit phases out the old values, as a grep for "mathspace" doesn't find any other active code with them. But so far this is the kind of change that someone completely new to latexml would made, since I consider myself mostly novice when it comes to the post-processing unit considerations.

Thanks for any tips!

@brucemiller
Copy link
Owner

looks plausible, and those few mathspace's were only used for internal spacing tweaks, so pretty innocuous allround.

@dginev dginev changed the title [WIP] phase out *mathspace mspace values phase out *mathspace mspace values Oct 16, 2022
@dginev
Copy link
Collaborator Author

dginev commented Oct 17, 2022

Alright, good to merge on my end if so. You can always revisit them in the other spacing work.

@brucemiller brucemiller merged commit ae17857 into brucemiller:master Oct 19, 2022
@brucemiller brucemiller deleted the update-mspace-values branch October 19, 2022 15:03
dlo pushed a commit to dlo/LaTeXML that referenced this pull request Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modernize mspace width values
2 participants