Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console not persistent visible during relaunch #312

Closed
vinsworldcom opened this issue Nov 14, 2023 · 2 comments · Fixed by #315
Closed

Console not persistent visible during relaunch #312

vinsworldcom opened this issue Nov 14, 2023 · 2 comments · Fixed by #315

Comments

@vinsworldcom
Copy link
Contributor

As @rdipardo points out in mohzy83/NppMarkdownPanel#90, the NppTbData.pszModuleName must be assigned to the DLL file name in order for Notepad++ to remember persistence. It is not:

m_data->pszModuleName = _T("Python Script");

Cheers.

@chcg
Copy link
Collaborator

chcg commented Nov 15, 2023

@vinsworldcom Thanks for forwarding this topic here and thanks @xomx for the PR.

@vinsworldcom
Copy link
Contributor Author

Just tested the artifact - works as expected for me with simple test leaving the window visible and closing - it's there on re-launch. Closing the window, it is not there on relaunch.

Thank you @xomx for the complete PR and @chcg for merging so quickly!

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants