From d40f9f42f05ab7e569f93c324a91a1d02031944e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCrgen=20Lange?= Date: Mon, 19 Sep 2016 18:28:17 +0200 Subject: [PATCH] Unnecessary other field tab (#2002) * Optional fields list filled * CHANGELOG.md --- CHANGELOG.md | 1 + src/main/java/net/sf/jabref/gui/entryeditor/EntryEditor.java | 2 ++ 2 files changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3a9600a6bcf..15dfe9acbce 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -59,6 +59,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# - Fixed loop when pulling changes (shared database) when current selected field has changed - Fixed [#1958](https://github.com/JabRef/jabref/issues/1958): Verbatim fields are no longer checked for HTML encoded characters by integrity checks - Fixed [#1937](https://github.com/JabRef/jabref/issues/1937): If no help page for the current chosen language exists, the english help page will be shown +- Fixed [#1996](https://github.com/JabRef/jabref/issues/1996): Unnecessary other fields tab in entry editor removed (BibTeX mode) ### Removed - The non-supported feature of being able to define file directories for any extension is removed. Still, it should work for older databases using the legacy `ps` and `pdf` fields, although we strongly encourage using the `file` field. diff --git a/src/main/java/net/sf/jabref/gui/entryeditor/EntryEditor.java b/src/main/java/net/sf/jabref/gui/entryeditor/EntryEditor.java index ec1c6f47759..0189a9fb824 100644 --- a/src/main/java/net/sf/jabref/gui/entryeditor/EntryEditor.java +++ b/src/main/java/net/sf/jabref/gui/entryeditor/EntryEditor.java @@ -239,6 +239,8 @@ private void setupFieldPanels() { if ((type.getOptionalFields() != null) && !type.getOptionalFields().isEmpty()) { if (!frame.getCurrentBasePanel().getBibDatabaseContext().isBiblatexMode()) { + displayedOptionalFields.addAll(type.getOptionalFields()); + addOptionalTab(type); } else { displayedOptionalFields.addAll(type.getPrimaryOptionalFields());