Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a label about the change size of the MR #8

Open
julioleitao opened this issue Aug 21, 2017 · 0 comments
Open

Add a label about the change size of the MR #8

julioleitao opened this issue Aug 21, 2017 · 0 comments

Comments

@julioleitao
Copy link
Collaborator

julioleitao commented Aug 21, 2017

"Developers should be encouraged to keep each individual change small, with larger changes preferably broken into a series of smaller changes that a reviewer can easily review in one go.

One way in which keeping changes small is encouraged is that the code review tools label each code review with a description of the size of the change, with changes of 30-99 lines added/deleted/removed being labelled 'medium-size' and with changes of above 300 lines being labelled with increasingly disparaging labels, e.g. 'large' (300-999), 'freakin huge' (1000-1999)" Fergus Henderson at Software Engineering at Google.

We could have a label at the notification to show the impact of the MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant