Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Showing less common stock values #6

Open
jlangy opened this issue Jul 29, 2020 · 0 comments
Open

Bug: Showing less common stock values #6

jlangy opened this issue Jul 29, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jlangy
Copy link
Collaborator

jlangy commented Jul 29, 2020

Describe the bug
App is currently using raw values for stock prices, not adjusted values.

To Reproduce
Steps to reproduce the behavior:

  1. Look at ACB stock on traderu.io
  2. Stock is undervalued at all points, due to using raw values

Expected behavior
Should show adjusted values, as these are more common

Additional context
Problem comes from the alpha vantage endpoints we are hitting. The api has adjusted endpoints we should use instead. See https://www.alphavantage.co/documentation/#dailyadj. Updating the url's in the seed functions should fix this, just need to make sure the data format matches

@jlangy jlangy added the bug Something isn't working label Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants