Test API integration #131
Draft
Test API integration #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More to do, and definitely some refactoring needed, but moving towards something functionally viable. |
bscan
reviewed
Jun 3, 2024
| run.started(fileItem); | ||
| // Extract via Test2::API to JSON | ||
| const execPromise = new Promise((resolve, reject) => { | ||
| child_process.exec(`perl -e ' |
There was a problem hiding this comment.
We'll need to update this to use settings.perlPath instead of "perl" somehow.
This is the way I call external perl scripts in the server side:
const process = async_execFile(settings.perlPath, settings.perlParams.concat(tidyParams), { timeout: 25000, maxBuffer: 20 * 1024 * 1024 });
|
Thanks for the feedback, I'll spend some more time working on this when I can. This month is looking fairly busy for me, and I still have a talk that needs writing for TPRC! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21
Kind of winging it with these changes but wanted to get the ball rolling on introducing this feature. Bare minimum functionality should be present with this.