Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little advice #53

Closed
wingchaos opened this issue Apr 13, 2018 · 16 comments
Closed

Little advice #53

wingchaos opened this issue Apr 13, 2018 · 16 comments

Comments

@wingchaos
Copy link

wingchaos commented Apr 13, 2018

A. supports ActWebScoket

B. adds a button to stop encounter

C. hasn't thought well yet

LOL

@bsides
Copy link
Owner

bsides commented Apr 14, 2018

Hi @wingchaos!
Sure thing I will implement it in the next few days. Thanks for posting 👍

@bsides
Copy link
Owner

bsides commented Apr 27, 2018

Hey @wingchaos could you explain suggestion A for me? I'll try to implement B this weekend 👍

@EvilSakray
Copy link

EvilSakray commented Apr 29, 2018

A. is kinda already done @bsides
You just need to have references to the ACT WebSocket scripts urls (maybe jquery as well) on your parser html layout in the head section:

<head> 
[...]
<script src="https://ZCube.github.io/ACTWebSocket/Sample/actwebsocket.js"></script>
<script src="https://ZCube.github.io/ACTWebSocket/Sample/actwebsocket_compat.js"></script>
[...]
</head>

See: https://github.com/ZCube/ACTWebSocket

I don't think it requires anything more from you.

Then users need to have the actual ACTWebSocket plugin to make use of it.
However if you host the overlay yourself with ActWebSocket on a server that obviously supports websocket, it means people will be able to send their fight data to your server which might generate trafic you don't want. (Unless I'm wrong about that part? D: )

Haeru overlay supports it for instance:
http://haeru.xyz/index.html?HOST_PORT=ws://[Local IP:Port of the server ACTWebSocket plugins creates]

This is mainly used for people streaming (they can easily capture the overlay into their stream using a BrowserSource that renders a web page instead of using Monitor Capture and such, which is pretty bad for performances)

Hope I managed to be clear 😢

@bsides
Copy link
Owner

bsides commented Apr 30, 2018

Awesome @EvilSakray, it made perfect sense. I'll look more into them today. Also, I always wanted to stream with the parser too, thanks for sharing it!

@bsides
Copy link
Owner

bsides commented May 6, 2018

Hi @EvilSakray, I tried to implement it but I don't think it's working. I'll look more into it. Right now the JS are there (and throwing some errors) but I could just put it inside my build to fix it (to transform new js to old js).

@bsides
Copy link
Owner

bsides commented May 6, 2018

It's definitely not working. I would need an example of implementation because those JavaScript are just samples and they don't tell much of how the plugin works. @HAERUHAERU code is very long so it's being a little hard to find where it is so maybe I could ask him for some advice. I'll let you know whenever it's ready.

@bsides
Copy link
Owner

bsides commented May 7, 2018

Well I have news.

Good news: I got it working! It was as pleasant as I would suppose but it really works.
Bad news: I can't get it to work on the current URL because github serves from HTTPS, which is Secure HTTP and the websocket serves from an unsecured protocol (WS > should be WSS). There is an option in the ActWebSocket Plugin to serve it with SSL but Chrome would still complain about a certificate, since although you'd be serving as WSS, you're not really passing along a secure protocol without a certificate.

To sum it up, I opened an issue to the author of ActWebSocket ZCube/ACTWebSocket#21 to try to solve this.

EDIT: I posted a working version at my server, so if you want to test it, the URL for the overlay is: http://rafaelp.com.br/horizoverlay

Meanwhile, if you want to test it, you could do it by running locally. It's not easy, but it works.

Instructions to run locally:

  1. Install nodejs
  2. Install git
  3. Clone this repository: on a command prompt, type git clone https://github.com/bsides/horizoverlay.git
  4. Go to the project's folder: cd horizoverlay
  5. Once inside the folder, install its dependencies by running: npm install
  6. Go to the branch actwebsocket: git checkout actwebsocket (if it gives you an error, try git checkout origin/actwebsocket)
  7. After this command is complete, type: npm run build
  8. You'll have a subfolder now called build with an index.html you could put inside OverlayPlugin.
  9. To make it work, you should host it. To host locally, run npm i -g serve then, inside the project's folder, run serve build. It will host locally the pages from the build folder.
  10. You can now visit http://localhost:5000 and see the overlay working. You could also put that url into ActWebSocket plugin.

It's a lot of work but I'll to solve this asap.

Thanks for the input!

@ZCube
Copy link

ZCube commented May 7, 2018

I add reverse proxy for github.io
You can use it likes http://localhost:10501/github/bsides/horizoverlay/ with ACTWebSocket 1.3.3.2
So I'll close ZCube/ACTWebSocket#21

@EvilSakray
Copy link

@bsides Thanks I'll give it a try when I'm back from holidays.

@EvilSakray
Copy link

@bsides I had tried it, working fine except the sort order was reversed for me (unless it's a configuration client side, I didn't try without ACT Web Socket)

I had 8. = Highest DPS & 1. rank player = Lowest

@bsides
Copy link
Owner

bsides commented Jun 4, 2018

@EvilSakray Could you send me a screenshot of your config and your reverted order thing?

@EvilSakray
Copy link

EvilSakray commented Jun 14, 2018

Sorry for the late reply:

Sample

The lowest dps is rank 1 on the far left and highest rank 8 on the far right.. it should be the opposite?
It might come from how I configured ACT itself though, but unsure where to change that.

What configuration screen do you want a screenshot of?

@ghost
Copy link

ghost commented Jun 15, 2018

@bsides Sorry to hijack this issue but I guess it's the right spot to ask for help with ACTWebSocket. I have setup ACTWebSocket and can access the parser in the browser via http://rafaelp.com.br/horizoverlay/?HOST_PORT=ws://[::1]:10501/#/. Unfortunately there are two issue:

  1. At the end of an encounter the DPS bar completely disappears and the page turns empty which is really not expected. When running the parser in the OverlayPlugin it works as expected.
  2. Are the any ways to pass options to the page? I wanted to use the URL as a Browser Source in OBS for streaming, however I cannot change the options when embedding the page in my stream.

@EvilSakray
Copy link

EvilSakray commented Jun 15, 2018

@nearautomata As i'm also using browser source in OBS; i'll try answering D;

  1. Not sure, I thought the dps bar disapearing to only leave the area / fight length / raid dps was actually a feature. Unless you got nothing to show at all anymore once out of a fight, in which case I've got no clue. As far as I'm concerned, the area information bar being pretty transparent, i actually changed the css background-color of it through OBS itself since it lets you do so since I would not always see it well.

  2. You can configure the overlay first in OBS by setting this url in the BrowserSource first: http://rafaelp.com.br/horizoverlay/#/config
    Then right click the source and pick "Interact" to be able to set it up as you wish.
    Settings will be saved if you keep the same source object in your scene and just change the url back to
    http://rafaelp.com.br/horizoverlay/?HOST_PORT=ws://[::1]:10501/#/ once you're done.

@ghost
Copy link

ghost commented Jun 15, 2018

@EvilSakray

  1. In my case all combatants are disappearing and I have the location/target/duration bar disabled anyways. I don't know whether it's a feature or not but I dislike that everything disappears at the end of an encounter. If it's a feature, there should be an option to toggle that behaviour in the first place. Furthermore I stumbled upon even more bugs like combatants being in the opposite order or Limit Break not appearing in the list but still preventing the last (or first) combatant to be visible.
  2. That feature seems to be what I am looking for but it hasn't been implemented in Streamlabs OBS yet. Therefore i have to wait for it.

@bsides
Copy link
Owner

bsides commented Jul 4, 2019

Sorry for the very late reply, I'll look more into it in the next version of the overlay. For now, if you need anything (or the questions above are still valid) let me know in another issue, please.

Thanks again for bringing me this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants