Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order flipping #81

Open
Rawrington opened this issue Jul 23, 2019 · 2 comments · May be fixed by #82
Open

Order flipping #81

Rawrington opened this issue Jul 23, 2019 · 2 comments · May be fixed by #82
Labels
bug

Comments

@Rawrington
Copy link
Contributor

Rawrington commented Jul 23, 2019 •
edited
Loading

This is my own fault and I'm putting this issue here to let you know and implement the fix myself. Actwebsocket flips the order of combatants (low to high) compared to overlayplugin (high to low) I 'fixed' the ordering for actwebsocket because it looked wrong on my end and only briefly tested with overlayplugin, I'll fix this asap in a pull request by flipping actws data if it's detected
@Rawrington Rawrington linked a pull request Jul 24, 2019 that will close this issue
Open
@bsides
Copy link
Owner

bsides commented Jul 30, 2019

Oh the PR is there since then and I couldn't test it :( I'm going to try to push it tonight. In case I can't I'll just trust it will work 😉

@bsides bsides added the bug label Jul 30, 2019
@bsides
Copy link
Owner

bsides commented Nov 29, 2019

Hi @Rawrington could you tell if it's fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed Order Flipping (and sorted some tab issues) Rawrington/horizoverlay
2 participants
@bsides @Rawrington