Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No inventory at provided URL #105

Closed
flying-sheep opened this issue Jan 23, 2020 · 12 comments · Fixed by #109
Closed

No inventory at provided URL #105

flying-sheep opened this issue Jan 23, 2020 · 12 comments · Fixed by #109
Milestone

Comments

@flying-sheep
Copy link

flying-sheep commented Jan 23, 2020

$ curl -I 'https://docs.h5py.org/en/stable/objects.inv'
HTTP/2 200 
date: Thu, 23 Jan 2020 16:15:59 GMT
content-type: application/octet-stream
content-length: 2065
...
$ `sphobjinv co plain -u 'https://docs.h5py.org/en/stable/objects.inv'`
No inventory at provided URL.
Attempting "https://docs.h5py.org/en/stable/objects.inv/objects.inv" ...
Attempting "https://docs.h5py.org/en/stable/objects.inv" ...
Attempting "https://docs.h5py.org/en/objects.inv" ...
Attempting "https://docs.h5py.org/objects.inv" ...
 
No inventory found!

curl -I --http1.0 also works, no idea what fails here…

@bskinn
Copy link
Owner

bskinn commented Jan 23, 2020

Bah, yeah, I've seen this before -- some of the documentation websites have added some kind of filter to incoming traffic, which blocks the urllib.request requests that sphobjinv uses. Looks like I really have to figure this out.

Related, I have plans (#99 & #106) to improve the CLI output so that it's more obvious what's gone wrong when stuff happens.

@bskinn
Copy link
Owner

bskinn commented Jan 23, 2020

In the near term, best solution is just to download the objects.inv manually by whatever means, and then load as the local file.

@flying-sheep
Copy link
Author

OK, great to hear this is known already!

@bskinn
Copy link
Owner

bskinn commented Jan 24, 2020

Thought so, it just takes a custom header... in manual testing, this solution worked.

I'll get this fix into 2.0.1 as soon as I can; the enhanced CLI output will come later on.

@bskinn bskinn added the type: bug 🪲 Something is wrong label Jan 24, 2020
@bskinn bskinn added this to the v2.0.1 milestone Jan 24, 2020
@bskinn
Copy link
Owner

bskinn commented Jan 24, 2020

Once fixed, restore flask to trial objects.inv's (undo 7a5eb6c).

Also add h5py objects.inv to trial objects.inv's

@bskinn
Copy link
Owner

bskinn commented Jan 24, 2020

Also add nonloc tests for pulling flask and h5py inv files.

@flying-sheep
Copy link
Author

Great, thank you! Note that if you compare the contents of h5py’s objects.inv, they might change soon (I made a PR so they export their stuff as h5py.Class instead of plain Class)

@bskinn
Copy link
Owner

bskinn commented Jan 24, 2020

<nod>, noted, thanks! I'll just add h5py's inventory as a "can I pull this one down?" sanity check, then, rather than using it for detailed tests on the content.

bskinn added a commit that referenced this issue Jan 24, 2020
Fixes #105; still need direct download tests of Flask, h5py
bskinn added a commit that referenced this issue Jan 24, 2020
@bskinn
Copy link
Owner

bskinn commented Jan 24, 2020

Will get the 2.0.1 release cut as soon as I can manage it. 👍

@flying-sheep
Copy link
Author

Awesome, thanks!

@bskinn
Copy link
Owner

bskinn commented Jan 27, 2020

v2.0.1 is up on PyPI -- lemme know how it works!

@flying-sheep
Copy link
Author

Nice, works flawlessly now, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants