Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 UMD bundle is missing local source dependencies #138

Merged
merged 1 commit into from
Jul 15, 2021
Merged

fix: 🐛 UMD bundle is missing local source dependencies #138

merged 1 commit into from
Jul 15, 2021

Conversation

GordonSmith
Copy link
Contributor

@GordonSmith GordonSmith commented Jun 4, 2021 •
edited
Loading

Description

Current UMD bundle contains several invalid "require" statements
(causing it to fail when used with an AMD loader):

  • require("./cloneNode")
  • require("./embedImages")
  • require("./embedWebFonts")
  • require("./createSvgDataURL")
  • require("./applyStyleWithOptions")
  • require("./util");

Rather than bundling the "commonjs" generated sources, this change lets rollup bundle via ES6
modules (which it prefers).

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@biiibooo
Copy link
Contributor

biiibooo bot commented Jun 4, 2021

👋 @GordonSmith

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@GordonSmith
fix: 🐛 UMD bundle is missing local source dependencies
425462d 
Current UMD bundle contains several invalid "require" statements
(causing it to fail when used with an AMD loader):
  * require("./cloneNode")
  * require("./embedImages")
  * require("./embedWebFonts")
  * require("./createSvgDataURL")
  * require("./applyStyleWithOptions")
  * require("./util");

Rather than bundling the "commonjs" generated sources, this change lets rollup bundle via ES6
modules (which it prefers).

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith mentioned this pull request Jun 4, 2021
Closed
10 tasks
@biiibooo
Copy link
Contributor

biiibooo bot commented Jun 25, 2021

Hiya!
This PR has gone quiet. Spooky quiet. 👻
We get a lot of PRs, so we currently close PRs after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this PR or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this PR open!
Thanks for being a part of the Antv community! 💪💯

@biiibooo biiibooo bot added the stale label Jun 25, 2021
@GordonSmith
Copy link
Contributor Author

Bump

@biiibooo biiibooo bot removed the stale label Jun 26, 2021
@bubkoo bubkoo merged commit 67be116 into bubkoo:master Jul 15, 2021
@biiibooo
Copy link
Contributor

biiibooo bot commented Jul 15, 2021

👋 @GordonSmith Congrats on merging your first pull request! 🎉🎉🎉

github-actions bot pushed a commit that referenced this pull request Jul 23, 2021
@semantic-release-bot
chore(release): 1.7.0 [skip ci]
17f3a27 
# [1.7.0](v1.6.2...v1.7.0) (2021-07-23)

### Bug Fixes

* 🐛  UMD bundle is missing local source dependencies ([#138](#138)) ([67be116](67be116))
* 🐛 fontAwesome icons are not included in the resulting image on safari ([#131](#131)) ([c6ebb34](c6ebb34))

### Features

* ✨ Add viewBox attribute to SVG ([#146](#146)) ([b4ac1d8](b4ac1d8))
@biiibooo
Copy link
Contributor

biiibooo bot commented Jul 23, 2021

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

@biiibooo biiibooo bot added the released label Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @bubkoo