feat: return 'this' from CircuitBreaker.fallback

nodeshift · Dec 6, 2016 · 159c006 · 159c006
1 parent 5ddcbc4
commit 159c006
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/circuit.js b/lib/circuit.js
@@ -122,6 +122,7 @@ class CircuitBreaker extends EventEmitter {
    */
   fallback (func) {
     this[FALLBACK_FUNCTION] = func;
+    return this;
   }
 
   /**

diff --git a/test/test.js b/test/test.js
@@ -172,6 +172,17 @@ test('Passes arguments to the fallback function', (t) => {
     });
 });
 
+test('Returns self from fallback()', (t) => {
+  circuitBreaker(passFail, { maxFailures: 1 })
+    .fallback(() => {})
+    .fire(1)
+    .then((result) => {
+      t.equals(result, 1);
+    })
+    .then(t.end)
+    .catch(t.fail);
+});
+
 test('CircuitBreaker status', (t) => {
   const breaker = circuitBreaker(passFail, { maxFailures: 1 });
   const deepEqual = (t, expected) => (actual) => t.deepEqual(actual, expected);
-Original file line number
+Diff line change
@@ Expand Up / @@ -122,6 +122,7 @@ class CircuitBreaker extends EventEmitter { @@
        */
       fallback (func) {
         this[FALLBACK_FUNCTION] = func;
+        return this;
       }
       /**
@@ Expand Down @@