Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .DS_Store (and perahps other dot files) #640

Closed
ericrafalovsky opened this issue Feb 15, 2023 · 1 comment
Closed

Ignore .DS_Store (and perahps other dot files) #640

ericrafalovsky opened this issue Feb 15, 2023 · 1 comment

Comments

@ericrafalovsky
Copy link

Current behavior

Upon encountering unexpected files, bazel-remote fails to start.

For example,

mkdir /home/vagrant/.cache/bazel-remote
touch /home/vagrant/.cache/bazel-remote/.DS_Store
./bazel-remote --dir=/home/vagrant/.cache/bazel-remote --max_size=20 
2023/02/15 21:32:37 bazel-remote built with go1.19.4 from git commit b899a9d0f9d086a25e9ec51ccba8dafbc36ca8eb.
2023/02/15 21:32:37 Initial RLIMIT_NOFILE cur: 2560 max: 2560
2023/02/15 21:32:37 Setting RLIMIT_NOFILE cur: 2560 max: 2560
2023/02/15 21:32:37 Storage mode: zstd
2023/02/15 21:32:37 Zstandard implementation: go
2023/02/15 21:32:37 Limiting concurrent file removals to 5000
2023/02/15 21:32:37 Loading existing files in /home/vagrant/.cache/bazel-remote.
2023/02/15 21:32:37 Scanning cache directory with 16 goroutines
2023/02/15 21:32:37 Failed to scan cache dir: Unexpected file: .DS_Store
2023/02/15 21:32:37 Loading of existing cache entries failed due to error: Unexpected file: .DS_Store

Feature request

bazel-remote should ignore .DS_Store files (as well as perhaps some other common types of dot files). When running bazel-remote on MacOS, which admittedly is perhaps uncommon, such files can be commonly encountered and this issue can be unnecessary disruptive in causing bazel-remote to fail to start up.

Thanks for all your work on this awesome project ❤️ !

@mostynb
Copy link
Collaborator

mostynb commented Feb 16, 2023

Sounds like a reasonable feature request- landed a change which I think should work.

Thanks for all your work on this awesome project heart !

Thanks for the kind words- I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants